NeoResearch / neocompiler-eco

NeoCompiler Eco: compile, deploy, test NEO smart contracts and tools for the decentralized web
https://neocompiler.io
MIT License
37 stars 21 forks source link

dotnet Dockerfile can be largely simplified #39

Closed nunojusto closed 5 years ago

nunojusto commented 6 years ago

https://github.com/NeoResearch/neocompiler-eco/blob/master/docker-ubuntu-dotnet/Dockerfile This Dockerfile is installing all by hand.

Why not use the official Microsoft ubuntu release docker image? https://hub.docker.com/r/microsoft/dotnet/ With this you can have all the updates done by them in the official way.

Also, if this is only to run csharp stuff already compiled (published) you don't need SDK, you can use the dotnet runtime.

igormcoelho commented 6 years ago

good idea! lets try this one.We need both because this the base image for compilers , neocli and neotests.

vncoelho commented 6 years ago

Let's make some experiments. It may simplify our scripts and reduce image size (can also make things faster).

Thanks for suggesting.