search

NeoSpark314 / BeepSaber

A basic implementation of the Beat Saber VR game mechanic in the Godot Game Engine for Oculus Quest (and other VR headsets)
MIT License
104 stars 30 forks source link

Highscores, joystick scrolling, play count tracking, OnlineLibrary features #18

Closed hankedan000 closed 3 years ago

hankedan000 commented 3 years ago
leandrodreamer commented 3 years ago

great additions so far, but i think i found a bug, i was unable to get out of the score screen, buttons stay disabled

https://user-images.githubusercontent.com/26260718/121462633-80d99880-c976-11eb-8ecf-385a1d153040.mp4

also on that screen i felt some frame drops, but it may be because of recording, not sure

hankedan000 commented 3 years ago

Thanks for testing! I pushed a commit that reconnects the text input signal from the keyboard. This must have gotten dropped in a bad conflict resolution. I didn't pick up on this because once you have existing names in the highscore table, you can pick from those name instead of entering your name via the keyboard.

As for the frame drop, I think I've noticed that it's related to the keyboard UI. I tried applying some simple flat themes to the keyboard in another project and it also caused frame drop. I'll take a look around to see if it's anything else I could have introduced though.

You comment also reminds me that I wanted to add some sort of notification that you got a new high score. Maybe some flashy test that pop up on the score board, or even a little giggle. I'll probably work on adding that before closing the PR.

NeoSpark314 commented 3 years ago

These are some great additions :-); very nice. I will give it a test later today; the PR is already quite big; so I think it would be better to merge it without major changes and add the highscore notification in a separate PR afterwards. what do you think?

hankedan000 commented 3 years ago

Thanks! Sounds good to me.