NeoSpark314 / godot_oculus_quest_toolkit

An easy to use VR toolkit for Oculus Quest development using the Godot game engine
MIT License
367 stars 38 forks source link

OQ_Toolkit as plugin #40

Open Wavesonics opened 4 years ago

Wavesonics commented 4 years ago

PR for #38

Wavesonics commented 3 years ago

Is there any interest in continuing down this road?

We could separate out some of the changes. For instance, just having a plugin that adds vr_autoload for you would be beneficial.

We can pick and choose whats in here:

  1. Add plugin: 1a. Add vr_autoload as singleton automatically 1b. Add OQT classes as built in classes (we can ditch this one if it's wierd) 1c. Move OQT into addons/
  2. Automatic vr initializtion in OQ_ARVROrigin.gd

1 and 1a make a lot of sense to me.

1c makes some sense if we have a plugin script. But if this is a sticking point, there are options. We could put the plugin.cfg and plugin.gd in /addons/OQT and have the rest at the root level, or even just put the plugin in with the root level OQT directory.

Personally I'm rooting for moving the whole OQT directory into addons/ as that's where it lives for me, and would save me some time each time I need to upgrade. But I understand that might not be what others want.

1b and 2 I could take or leave.