search

NeoSpark314 / godot_oculus_quest_toolkit

An easy to use VR toolkit for Oculus Quest development using the Godot game engine
MIT License
367 stars 38 forks source link

Feature_UIRayCast references non-member variable vr.ovrHandTracking #57

Closed goatchurchprime closed 3 years ago

goatchurchprime commented 3 years ago

This line: https://github.com/NeoSpark314/godot_oculus_quest_toolkit/blob/master/OQ_Toolkit/OQ_ARVRController/scripts/Feature_UIRayCast.gd#L30 if (vr.ovrHandTracking):

causes an error because ovrHandTracking is not listed anywhere in https://github.com/NeoSpark314/godot_oculus_quest_toolkit/blob/master/OQ_Toolkit/vr_autoload.gd

It's not obvious what it is supposed to be, or if there is a huge block of code missing.

NeoSpark314 commented 3 years ago

thanks for finding this; this functionality was moved in some recent refactoring and I forgot this code location. I'll fix it

goatchurchprime commented 3 years ago

When this works I'll extend https://github.com/goatchurchprime/OQ_Networking_Demo to handing the hand-tracking, which is always pretty compelling. It's a pretty neat demo when you can network in on someone's desktop screen running a flat WebXR version with your hand-tracking all working. I can pack all the transforms down as Vector3s so they don't take so much bandwidth.

NeoSpark314 commented 3 years ago

should be fixed now on master