search

Neocky / pluGET

📦 Powerful Package manager which updates plugins & server software for minecraft servers
Apache License 2.0
150 stars 27 forks source link

Error Handling To Address Paper Check Crashes #18

Closed ZandercraftGames closed 3 years ago

ZandercraftGames commented 3 years ago

Sometimes the program will crash when it cannot detect certain information about the paper version. While this doesn't address the root issue (why the program is not properly detecting information from the paper server), it does add error handling that prevents the program from crashing. This will, at the very least, allow users to be able to report where the issue is happening and prevent them from stopping use of the software because it crashes at times.

This also makes the paperCheckForUpdate function return false if an error is encountered. This can then be used if you wish to handle the error in some way in the future.

Neocky commented 3 years ago

Hey, thank you so much for your pull request. I will check it and come back to you!

ZandercraftGames commented 3 years ago

Hey, thank you so much for your pull request. I will check it and come back to you!

Thanks! If there is anything you want changed, just tell me. I made some pretty quick changes and some of my coding might be a little dirty.

ZandercraftGames commented 3 years ago

Made the requested changes. They have been pushed and added to the PR.

Neocky commented 3 years ago

Hey @ZandercraftGames, i merged it and released an update: v1.5.3 Thank you again so much for your PR! 😃

...and thanks for flying with pluGET! 🚀

ZandercraftGames commented 3 years ago

Hey @ZandercraftGames, i merged it and released an update: v1.5.3 Thank you again so much for your PR! 😃

...and thanks for flying with pluGET! 🚀

😄