Neocky / pluGET

📦 Powerful Package manager which updates plugins & server software for minecraft servers
Apache License 2.0
150 stars 27 forks source link

Inaccurate Update Notifiers #20

Closed greysilly7 closed 3 years ago

greysilly7 commented 3 years ago

Describe the bug A clear and concise description of what the bug is. Tells you there is an update if the current version number is higher then latest

To Reproduce Steps to reproduce the behavior:

  1. Run Pluget
  2. Run check all
  3. Get False Updates

Expected behavior A clear and concise description of what you expected to happen. It to report false

Screenshots If applicable, add screenshots to help explain your problem. image

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

The thing in question is this [16] DriveBackupV 2 1.3.4 True full output


Checking: all
┌─────┬────────────────────────────────┬──────────────┬──────────────┬───────────────────┐
│ No. │ Name                           │ Installed V. │ Latest V.    │ Update available  │
└─────┴────────────────────────────────┴──────────────┴──────────────┴───────────────────┘
   [1]  VoidGenerator                    1.7.0          1.7.0          False
   [2]  Spleef                           2.1.1          2.1.1          False
   [3]  InfoBook                         3.0            InfoBook 3.0   False
   [4]  Vault                            1.7.3-b131     1.7.3          False
   [5]  FastAsyncWorldEdit-Bukkit-16-688.jar1.16-688;71f7103N/A            N/A  
   [6]  worldguard-bukkit                7.0.4          N/A            N/A  
   [7]  DiscordSRV-Build                 1.22.0         1.22.0         False
   [8]  ProtocolLib                      4.6.1-SNAPSHOT-b501N/A            N/A  
   [9]  PexTabCompleter                  1.3.0          N/A            N/A  
  [10]  PermissionsEx                    1.23.5         N/A            N/A  
  [11]  ImageOnMap                       4.1.2          4.1.2          False
  [12]  thebridge                        1.1.1          N/A            N/A  
  [13]  CoreProtect                      19.5           19.5           False
  [14]  SkinsRestorer                    14.0.2         14.0.2         False
  [15]  GriefPrevention                  16.17.1-2b6919116.17.1        False
  [16]  DriveBackupV                     2              1.3.4          True 
  [17]  LibsDisguises-24-Free.jar        10.0.24        N/A            N/A  
  [18]  EssentialsX                      2.18.2.0       N/A            N/A  
  [19]  PlaceholderAPI                   2.10.9         2.10.9         False
  [20]  EssentialsXChat                  2.18.2.0       N/A            N/A  
  [21]  AuthMe                           5.4.0          5.6.0-beta2    True 
  [22]  WorldGuardExtraFlags             4.1.5-SNAPSHOT N/A            N/A  
  [23]  Citizens-27-b2300.jar            2.0.27-SNAPSHOT (build 2300)N/A            N/A  
  [24]  Multiverse-Inventories           4.2.2          N/A            N/A  
  [25]  HolographicDisplays              2.4.6          N/A            N/A  
  [26]  Multiverse-Core                  4.2.2          4.2.2          False
Outdated plugins: [2/26]```

Potential Fix: You could check the plugins current version against the latest
greysilly7 commented 3 years ago

Nevermind it took the V2 part in the name and used that for the version