search

Neocky / pluGET

📦 Powerful Package manager which updates plugins & server software for minecraft servers
Apache License 2.0
150 stars 27 forks source link

Added custom port support for FTP access. #38

Closed TheDudeFromCI closed 3 years ago

TheDudeFromCI commented 3 years ago

Changing the port in the config should now work as intended for FTP mode.

Neocky commented 3 years ago

Hey @TheDudeFromCI,

thank you so much for your pull request. 😃 Your code looks good but i have found an issue.

FTP will always use the port from the config.ini file and the default port at creation is 22 which won't work as a default FTP Port which uses 21 as default. So if you wanted to use FTP instead of SFTP you had to switch to FTP mode AND change the default port which is unnecessary complicated for the default user.

I would much more like if there would be two default port options in the config. One exists in the form of the SFTP default port and then add one for the FTP default port.

I think this would be a good approach to the default port problem. What do you think?

TheDudeFromCI commented 3 years ago

Alright, applied the changes.

Neocky commented 3 years ago

Hey @TheDudeFromCI,

merged your PR in update: v1.6.8

Thank you again so much for the pull request! 😃

...and thanks for flying with pluGET 🚀