search

Neon22 / inkscape-LasercutBox

Creates a tabbed box with kerf adjustments. Set inside or outside dimensions, independent tab counts for each axis, corner option. Have a tight fit with kerf adjustment, or use the least amount of material and have a sloppy fit.
GNU General Public License v2.0
59 stars 21 forks source link

added support for Inkscape 1.0-beta #6

Closed dangrie158 closed 4 years ago

dangrie158 commented 4 years ago

I just added support for Inkscape 1.0 Beta by fixing all deprecation warnings.

The only change that was necessary to fix errors with the previous version was to remove the first or second argument from horizontal or vertical moves from a Path respectively. This also broke the functions thin() and trim_svg_path(). I first tried fixing them functionally, however I could not really find a case where they actually affected the output. furthermore, the code in trim_svg_path() seemed to be duplicated in thin().

Let me know if I overlooked something. I was not yet able to test backwards compatibility with 0.9X versions, however if this is a breaking change I would not recommend to merge the changes until 1.0 is final.

Neon22 commented 4 years ago

Thanks Daniel, I'll try to get to it soon. still doing some work in 0.92.4 and not ready to move to 1. 0 yet.

johnflux commented 4 years ago

I just tested this on :

Inkscape 1.0 (4035a4fb49, 2020-05-01)

And it caused Inkscape to just hang after pressing doing Extensions->Render->lasercut box then press "Ok".

johnflux commented 4 years ago

It works well after reducing the number of tabs. It hangs if the number of tabs is too high (it was 5 for the depth by default, but my depth was only 15mm.

Neon22 commented 4 years ago

Thanks so much for your help with this. finally updated and tested and added to the inkscape extensions website.