Neon22 / inkscape-jigsaw

An extension for Inkscape that creates jigsaw shaped pieces. Options for back, and single cut pieces.
GNU General Public License v2.0
91 stars 16 forks source link

Older version needed #21

Closed uwefrank closed 3 years ago

uwefrank commented 3 years ago

The actual version does not run under Inkscape 0.92. I must however keep that beacuse of another extension I need. Would it be possible to provide also an previous version of the extension. Besides that it is really good.

Neon22 commented 3 years ago

what is the other extension that needs updating. Maybe I can fix that one.

uwefrank commented 3 years ago

Hi Neon22, pretty quick reply! Thanks. the other extension is the JTech Photonics gcode generator. It works only well under 0.92. When I use the new version of it (beta) under 1.01 it generates gcode that tries to drive my 3D printer/cutter head over the limits of the frame. There is some scaling issue. I already thought about writing a postprocessor. As far as I coudl find out it upscales the coordinates by a factor of 3.5 or so. Maybe a inch/centimeter issue? I looked already through the code but it is really a big chunk of code.

So I thought it would be the easiest to run a previous version of the jigsaw extension until the JTech guys have fixed the code. It is already reported as a bug.

Neon22 schrieb:

what is the other extension that needs updating. Maybe I can fix that one.

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/Neon22/inkscape-jigsaw/issues/21# issuecomment-777383376

uwefrank commented 3 years ago

Besides that I want to say that this is a great extension. Like it a lot.

Neon22 commented 3 years ago

This page indicates there is a beta for V1.0

Please let me know how you get on ?

Neon22 commented 3 years ago

Oops yes I see that. sorry not concentrating :( I'll check it. Actually newer version 2.0 here: https://github.com/JTechPhotonics/J-Tech-Photonics-Laser-Tool/releases/tag/v2.0-beta.2

uwefrank commented 3 years ago

Yes, I tried that too. No change. There's a fundamental bug in.

Neon22 schrieb:

This page indicates there is a beta for V1.0

Please let me know how you get on ?

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/Neon22/inkscape-jigsaw/issues/21# issuecomment-777976064

Neon22 commented 3 years ago

Looked through the code. I added a note on the Jumbo github issue. It looks to me like the some units are being assumed. I don't have time to try to fix the code just at this time and the only way I could test it would be to have a result that was correct to compare to.

So I'd suggest you try creating a simple shape with a new doc initialised in mm or inches, or pixels and submit the svg file that fails as well as any that work as examples to the jumbo issue:

uwefrank commented 3 years ago

Ok. Thanks for caring. addtl comment: If a shape is created in Inkscape it works fine in both versions. But if it is pasted from an external source it does not work. Creates sometimes even negative y coordinates in 1.01.

Neon22 commented 3 years ago

OK that's super useful news, alas link does not resolve. svg is text and probably not too large you could cut and paste it in here.

Neon22 commented 3 years ago

OK. They think the bug is fixed. please let me know if its working in latest Inkscape.

Neon22 commented 3 years ago

@uwefrank did they update and did it work for you. Can we close this issue ?

uwefrank commented 3 years ago

Hi Neon22, yes, please close down the issue. Thanks.

Neon22 schrieb:

@uwefrank did they update and did it work for you. Can we close this issue ?

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/Neon22/inkscape-jigsaw/issues/21# issuecomment-878734035