search

NeonGeckoCom / NeonCore

Neon Core extends Mycroft core with more modular code, extended multi-user support, and more.
Other
78 stars 47 forks source link

Duplicated language utils #148

Closed NeonDaniel closed 2 years ago

NeonDaniel commented 3 years ago

neon_core.language and neon_utils.language_utils should be consolidated into a single location (probably neon_utils). Possibly consider moving those to a new neon-lang-utils package? TranslatorFactory and DetectorFactory could be useful on their own...

NeonDaniel commented 3 years ago

https://github.com/NeonGeckoCom/neon-skill-utils/pull/208

JarbasAl commented 3 years ago

maybe we should move the factories into ovos plugin manager like ovos-core is doing?

they become simpler also, because they keep strings with plugin name instead of references

NeonDaniel commented 3 years ago

Not sure about the factories if they're still NeonCore-specific, but the base classes I think make sense in OPM