search

NeonGeckoCom / NeonCore

Neon Core extends Mycroft core with more modular code, extended multi-user support, and more.
Other
52 stars 42 forks source link

[FEAT] Skills installed from config override existing versions #626

Open mikejgray opened 4 months ago

mikejgray commented 4 months ago

Objective

When adding skills.default_skills or extra_dependencies.skills, they no longer seem to overwrite existing skills. It would be nice to have that behavior available, even if behind a config flag.

Initial Implementation Requirements

Make it so any skills added will override pre-installed skills

Other Considerations

No response

NeonDaniel commented 3 months ago

Was the skill possibly reporting the same version as what was already installed? When I do something like that manually, I pass --no-deps --force-reinstall, but that would break dependency installation under normal circumstances.. That could probably be appended to the specific entry though in config?

mikejgray commented 3 months ago

Was the skill possibly reporting the same version as what was already installed? When I do something like that manually, I pass --no-deps --force-reinstall, but that would break dependency installation under normal circumstances.. That could probably be appended to the specific entry though in config?

I was explicit in passing a different version, which I frequently do when testing new versions of the Home Assistant skill/plugin. It also wasn't a situation where the version hadn't changed yet - it was for different PyPi versions of published packages. If you'd like to make the --no-deps --force-reinstall path the official recommendation and add to docs, that's probably fine, but this functionality was available until recently. Not sure when it changed or which commit changed it.