NeonGeckoCom / NeonCore

Neon Core extends Mycroft core with more modular code, extended multi-user support, and more.
Other
50 stars 41 forks source link

[BUG] ovos-utils 0.1.0 deprecated imports #658

Closed mikejgray closed 1 month ago

mikejgray commented 2 months ago

Description

❯ neon run-skills
2024-04-25 23:19:27.282 - neon-utils - neon_utils.configuration_utils:get_config_dir - WARNING - Deprecation version=2.0.0. Caller=neon_core.cli:98. Use `ovos_config.locations.get_xdg_config_save_path` directly
2024-04-25 23:19:27.527 - neon-utils - neon_utils.configuration_utils:_validate_config_env:535 - INFO - NEON_CONFIG_PATH=/Users/Mike/.config/neon
2024-04-25 23:19:27.527 - neon-utils - neon_utils.configuration_utils:_validate_config_env:539 - WARNING - NEON_CONFIG_PATH set, updating XDG_CONFIG_HOME to /Users/Mike/.config
2024-04-25 23:19:27.528 - neon-utils - neon_utils.packaging_utils:get_neon_core_root - WARNING - Deprecation version=2.0.0. Caller=neon_utils.configuration_utils:473. Use system modules to locate packages and resources
2024-04-25 23:19:27.873 - neon-utils - neon_utils.configuration_utils:_init_ovos_conf:512 - ERROR - Failed to override mycroft.configuration: cannot import name 'play_acknowledge_sound' from 'ovos_utils.sound' (/Users/Mike/Library/Caches/pypoetry/virtualenvs/neon-mac-sv8wqWXe-py3.10/lib/python3.10/site-packages/ovos_utils/sound.py)
2024-04-25 23:19:27.907 - neon-utils - neon_core.util.skill_utils:update_default_resources:137 - INFO - Directory exists; not linking default resources. /Users/Mike/.cache/neon/res
Traceback (most recent call last):
  File "/Users/Mike/Library/Caches/pypoetry/virtualenvs/neon-mac-sv8wqWXe-py3.10/bin/neon", line 8, in <module>
    sys.exit(neon_core_cli())
  File "/Users/Mike/Library/Caches/pypoetry/virtualenvs/neon-mac-sv8wqWXe-py3.10/lib/python3.10/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
  File "/Users/Mike/Library/Caches/pypoetry/virtualenvs/neon-mac-sv8wqWXe-py3.10/lib/python3.10/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
  File "/Users/Mike/Library/Caches/pypoetry/virtualenvs/neon-mac-sv8wqWXe-py3.10/lib/python3.10/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/Users/Mike/Library/Caches/pypoetry/virtualenvs/neon-mac-sv8wqWXe-py3.10/lib/python3.10/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/Users/Mike/Library/Caches/pypoetry/virtualenvs/neon-mac-sv8wqWXe-py3.10/lib/python3.10/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
  File "/Users/Mike/Library/Caches/pypoetry/virtualenvs/neon-mac-sv8wqWXe-py3.10/lib/python3.10/site-packages/neon_core/cli.py", line 104, in run_skills
    from neon_core.skills.__main__ import main
  File "/Users/Mike/Library/Caches/pypoetry/virtualenvs/neon-mac-sv8wqWXe-py3.10/lib/python3.10/site-packages/neon_core/skills/__init__.py", line 29, in <module>
    from neon_core.skills.decorators import intent_handler, intent_file_handler, \
  File "/Users/Mike/Library/Caches/pypoetry/virtualenvs/neon-mac-sv8wqWXe-py3.10/lib/python3.10/site-packages/neon_core/skills/decorators.py", line 37, in <module>
    from mycroft.skills.mycroft_skill.decorators import intent_handler, \
  File "/Users/Mike/Library/Caches/pypoetry/virtualenvs/neon-mac-sv8wqWXe-py3.10/lib/python3.10/site-packages/mycroft/__init__.py", line 18, in <module>
    from mycroft.messagebus.message import Message
  File "/Users/Mike/Library/Caches/pypoetry/virtualenvs/neon-mac-sv8wqWXe-py3.10/lib/python3.10/site-packages/mycroft/messagebus/__init__.py", line 14, in <module>
    from mycroft.messagebus.client.client import MessageBusClient
  File "/Users/Mike/Library/Caches/pypoetry/virtualenvs/neon-mac-sv8wqWXe-py3.10/lib/python3.10/site-packages/mycroft/messagebus/client/__init__.py", line 15, in <module>
    from mycroft.messagebus.client.client import MessageBusClient
  File "/Users/Mike/Library/Caches/pypoetry/virtualenvs/neon-mac-sv8wqWXe-py3.10/lib/python3.10/site-packages/mycroft/messagebus/client/client.py", line 20, in <module>
    import mycroft.util.process_utils
  File "/Users/Mike/Library/Caches/pypoetry/virtualenvs/neon-mac-sv8wqWXe-py3.10/lib/python3.10/site-packages/mycroft/util/__init__.py", line 22, in <module>
    from mycroft.util.audio_utils import (play_audio_file, play_wav, play_ogg,
  File "/Users/Mike/Library/Caches/pypoetry/virtualenvs/neon-mac-sv8wqWXe-py3.10/lib/python3.10/site-packages/mycroft/util/audio_utils.py", line 20, in <module>
    from ovos_utils.sound import play_acknowledge_sound, play_listening_sound, \
ImportError: cannot import name 'play_acknowledge_sound' from 'ovos_utils.sound' (/Users/Mike/Library/Caches/pypoetry/virtualenvs/neon-mac-sv8wqWXe-py3.10/lib/python3.10/site-packages/ovos_utils/sound.py)

A number of imports have been deprecated in ovos-utils 0.1.0, both with and without replacement, and need to be resolved before Neon will work with that codebase.

Steps to Reproduce

Install latest Neon code with 0.1.0a* Execute neon-skills run

Relevant Code

No response

Other Notes

No response

NeonDaniel commented 1 month ago

Neon references resolved in #654 and #656