[BUG] ovos-PHAL-plugin-mk1 installed on Mark 2 image

NeonGeckoCom / NeonCore

Neon Core extends Mycroft core with more modular code, extended multi-user support, and more.

Other

63 stars 44 forks source link

[BUG] ovos-PHAL-plugin-mk1 installed on Mark 2 image #686

Closed mikejgray closed 3 months ago

mikejgray commented 3 months ago

Description

The ovos-PHAL-plugin-mk1 plugin is getting installed on a Mark 2, which isn't terrible, but does pollute the PHAL logs unnecessarily.

Steps to Reproduce

Run a Mark 2 Neon image
pip list | grep -i ovos-PHAL-plugin-mk1

Relevant Code

No response

Other Notes

No response

NeonDaniel commented 3 months ago

The "Mark 2" image is really just the RPi image, so by default I have that plugin installed and disabled by default. Is it just logging that it is disabled, or is it trying to load?

mikejgray commented 3 months ago

The "Mark 2" image is really just the RPi image, so by default I have that plugin installed and disabled by default. Is it just logging that it is disabled, or is it trying to load?

It's trying to load, you can see it in the PHAL logs

NeonDaniel commented 3 months ago

Looks like a typo in the plugin name; I'll PR a fix today

NeonDaniel commented 3 months ago

I see that disabling a plugin that has a validator method isn't working in upstream PHAL, sending a PR there