search

NeonGeckoCom / neon_audio

Audio Module for Neon Core
Other
1 stars 8 forks source link

[BUG] tts-plugin module not matching pypi name causes failure to load #167

Open mikejgray opened 8 months ago

mikejgray commented 8 months ago

Description

In an edge case where the module of a TTS plugin does not match its PyPi name, and tts.package_spec is not available, the audio service will attempt to infer a package to install from PyPi based on tts.module. When it cannot find that package, the service errors out and does not load TTS, even if the plugin is available from extra_dependencies.audio.

Steps to Reproduce

extra_dependencies:
  audio:
    - neon-tts-plugin-coqui-remote
tts:
  module: mozilla_remote
  mozilla_remote: 127.0.0.1/api/tts

The issue is resolved by adding tts.package_spec: neon-tts-plugin-mozilla-remote.

Relevant Code

https://github.com/NeonGeckoCom/neon_audio/blob/3c78dea72820304227159a79b6b561d21e9dd2c7/neon_audio/utils.py#L70

Other Notes

No response