search

NeonGeckoCom / skill-device_controls

Device Control Center skill
Other
1 stars 2 forks source link

[FEAT] Screen brightness controls #92

Open mikejgray opened 4 months ago

mikejgray commented 4 months ago

Objective

There should be intents to handle brightness controls on the Mark 2.

Initial Implementation Requirements

Other Considerations

No response

NeonDaniel commented 4 months ago

Consider also a separate skill like the volume skill that only deals with screen controls.. I could see this integrating with the GUI and/or a PHAL plugin (i.e. dimming a matrix display like the Mark1) for the actual hardware interface

builderjer commented 4 months ago

It could then support hdmi also

JarbasAl commented 4 months ago

the enclosure api defines a brightness control message (for the mk1, this was for eyes), a skill for the enclosure API exists here https://github.com/OVOSHatchery/ovos-skill-mark1-ctrl , on my TODO to get it updated

the dimming is controlled by the shell companion plugin, we can probably unify the bus messages namespace and make the shell companion plugin respect the existing enclosure api

JarbasAl commented 4 months ago

It could then support hdmi also

also supported by the ovos-shell-companion plugin

builderjer commented 4 months ago

But not with voice. Guess the skill should just emit a bus message?