search

NeonGeckoCom / skill-local_music

Neon Skill for Local Music Playback
Other
4 stars 1 forks source link

[BUG] not selecting requested music #45

Open Olzeke51 opened 5 months ago

Olzeke51 commented 5 months ago

Description

"play local music ambient" was requested [beta 27.b35] also earlier versions received: └── rythmic ├── Cosmic_Flux.mp3

Steps to Reproduce

beta 27.b35 - Mark II, Pi4,2G, dev-kit R6 "play local music ambient" was requested - - received other music

(venv) neon@neon:~$ tree ~/Music
/home/neon/Music
├── A_Forest
│   ├── Cold.mp3
│   ├── Dark_Beach.mp3
│   ├── Fall_in_Line.mp3
│   ├── Gotch_Yer_Gun.mp3
│   ├── Humanity.mp3
│   ├── Its_Gonna_Rain.mp3
│   ├── Jack_Jack.mp3
│   ├── Nostalgia.mp3
│   ├── Ugly_Face.mp3
│   ├── Victim_of_Myself.mp3
│   └── Willard.mp3
├── ambient
│   └── Program0110.mp3
├── mello
└── rythmic
    ├── Cosmic_Flux.mp3
    └── Program0101.mp3

5 directories, 14 files

Relevant Code

No response

Other Notes

also have noted that skill will play all files in the designated directory, regardless of genre selected ' it is possible that I have my directory structure set up wrong, No artist, just genre

Olzeke51 commented 5 months ago

not_selected.tar.gz

NeonDaniel commented 5 months ago

If there's no ID3 tags on the MP3 files, the skill will try to infer an Artist and Album from the directory structure; in this case it looks like it will only parse the filename into a track name.

https://github.com/NeonGeckoCom/skill-local_music/blob/1f5bb882dc4ce06b789d117571a2228dc003a20d/util/__init__.py#L229-L249

I can think of a couple solutions/workarounds for this kind of situation:

Olzeke51 commented 3 months ago

running beta 08_08b1 - pi4,8G,usb/sdd, hdmi (no dsi), network cable

I used yt-dlp to download some youtube music into mp3 format then I used 'easy tag' to do author, title, genre tags. [on these two mp3s - the tags are different.] this display is from the linux 'tree' command.

(venv) neon@neon:~/Music$ cd ~
(venv) neon@neon:~$ tree Music
Music
├── Ambient1
│   └── Techno.mp3
└── Tribute.mp3

I asked Neon to 'play local music ambient1' it did play Techno.mp3 and displayed (iirc) the other music tags BUT then it jumped back a folder/dir and played Tribute !!! [not tagged 'ambient'}