search

NeonOpenAG / oagtoolbox

GNU General Public License v2.0
3 stars 0 forks source link

How are validation checks hooked up? #147

Closed stevieflow closed 6 years ago

stevieflow commented 7 years ago

I tested this file:

https://www.gov.uk/government/uploads/system/uploads/attachment_data/file/594562/1487926564.64.xml

It fails Validation tests against the schema:

http://validator.iatistandard.org/?perm=1487926564.64_1507558784.xml

But - OAg - says it passes: http://www.openag.org.uk/improveYourData/7

tobybatch commented 7 years ago

@stevieflow Validation checks are not currently hooked up. We use CoVE to parse incoming data and produce IATI XML. The hitch here is that if junk XML is uploaded CoVE still returns the XML to use, the toolbox assumes this is IATI XML.

@harryharrold do we intend to show validation errors?

tobybatch commented 7 years ago

I will add a json dump to the post upload screen

tobybatch commented 7 years ago

QV "Schema validation guidance and support - what fields work, what don’t, how to improve, guidance prompts"

tobybatch commented 7 years ago

@harryharrold have a look http://147.openag.org.uk/improveYourData/2 with the attached file.

ifad-activity-bad-rule.xml.zip

We now show validation / rule set errors.

harryharrold commented 7 years ago

I'll review this on Monday....

harryharrold commented 6 years ago

Reviewed....

Research suggests we should reject XML files that don't conform to the IATI standard on upload, rather than accepting them and treating them as cases for improvement - this approach is consistent with the copy expressed in our tested prototypes, and some feedback from the Rome "Big Questions".

@tobybatch will add this functionality to the test instance...

tobybatch commented 6 years ago

Better but still flawed. Use this file to test https://github.com/NeonOpenAG/oagtoolbox/blob/147-How_are_validation_checks_hooked_up/src/OagBundle/Resources/fixtures/ifad-activity-bad-rule.xml

http://147.openag.org.uk/app_dev.php

harryharrold commented 6 years ago

https://www.gov.uk/government/uploads/system/uploads/attachment_data/file/594562/1487926564.64.xml now fails.

...UX not very elegant. Improvement required.

tobybatch commented 6 years ago

Wierdly that passes for me on http://www.openag.org.uk but the UX is bound to need attention.

harryharrold commented 6 years ago

I have a plan for the UX - on upload, I get "x error file could not be uploaded" and:

Validation error, 'reporting-org': This element is not expected, expected is iati-identifier. in the xml at iati-activity/0/reporting-org Validation error, 'reporting-org': This element is not expected, expected is iati-identifier. in the xml at iati-activity/1/reporting-org Validation error, 'reporting-org': This element is not expected, expected is iati-identifier. in the xml at iati-activity/2/reporting-org Validation error, 'reporting-org': This element is not expected, expected is iati-identifier. in the xml at iati-activity/3/reporting-org

On Thu, Nov 16, 2017 at 7:04 PM, Toby Batch notifications@github.com wrote:

Wierdly that passes for me on http://www.openag.org.uk but the UX is bound to need attention.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/NeonOpenAG/oagtoolbox/issues/147#issuecomment-345029209, or mute the thread https://github.com/notifications/unsubscribe-auth/AA3ZTF2NIhccg-u1Nk96iOkZj0so5JrXks5s3Ic3gaJpZM4PymAs .

--

-- Harry Harrold

Project director, NeonTribe

Internet user experience designers and programmers

www.neontribe.co.uk 0845 689 0896 0778 900 1625 @harryharrold Martineau Memorial Hall, 21 Colegate, Norwich, NR3 1BN