search

Neopallium / bevy_water

Dynamic ocean material for Bevy.
https://neopallium.github.io/bevy_water/
116 stars 11 forks source link

Update to bevy v0.9.1 #1

Closed 66OJ66 closed 1 year ago

66OJ66 commented 1 year ago

Hi, this updates bevy_water to use the latest version of Bevy.

I made some changes to water.wgsl to get the shader to process, but I'm not experienced with WGSL (so can't be fully confident these changes are exactly correct).

Neopallium commented 1 year ago

Looks good. There is just a small 0.8 -> 0.9 migration change that was missed in the shader. I will push a commit for that in a minute.

Neopallium commented 1 year ago

@66OJ66 Thanks for the PR. Here is the small change to the shader based on the migration guide: https://github.com/Neopallium/bevy_water/commit/ea948f7048954b57d9411bed2d5fd574e6241199

I am not an expert at shaders, so not sure if that change is really needed or not.