search

Neos-Metaverse / NeosLocale

Locale assets for Neos VR
MIT License
29 stars 76 forks source link

British English [en-GB] #31

Open Nammi-namm opened 4 years ago

Nammi-namm commented 4 years ago

I decided to do a specific British English variant. Currently only find Colour spelled differently. Up for anyone else to submit more corrections.

ProbablePrime commented 4 years ago

en-gb usually has subtle changes in phrasing too to match words and phrases that aren't used as frequently as in the US.

Depending on your changes for en-gb it may not be worth it though.

ProbablePrime commented 4 years ago

Just saw #32

Based on the larger amount of references to Color i think it makes sense :)

Enverex commented 4 years ago

I went through this with the idea of changing any required phrasing but to be honest, there wasn't any at this point, only some more US/GB spelling switches. I assume some are likely to crop up eventually though (I was expecting "Trash -> Bin" swaps, but nothing like that yet).

DustInComp commented 3 years ago

This locale is kind of cluttering up the MISSING.md and will be as long as only GB-specific keys are in there. I think either en-GB should be excluded from the Missing Keys list, or strings that are confirmed to match British English should just be copied over from en.json.

Frooxius commented 3 years ago

Don't copy the strings over. I think I'll just split up the MISSING.md and generate one for each language in a subfolder instead, that way it'll scale a lot better as we get more languages too.

DustInComp commented 3 years ago

That might clean things up a bit but the file for en-gb still wouldn't be of much use if you can't tell which keys have and haven't been reviewed.

Frooxius commented 3 years ago

That's going to be a problem for any sub-languages like this, I don't plan on making specific exclusions for each of them. You can just ignore the file in those cases.

We could add a way to mark keys as reviewed, but that's extra implementation time, so I'm not sure when I'd do that.