search

Neos-Metaverse / NeosLocale

Locale assets for Neos VR
MIT License
30 stars 76 forks source link

Don't put any space in front of the colon. #567

Closed kazu0617 closed 3 years ago

kazu0617 commented 3 years ago

It is better to decide on the notation before merging, but it is customary for Json to not include a space before the colon (in fact, in some cases, this is automatically reflected when saving using VSCode). In addition, the MMC text added this time is also written in this way.

So, if it is possible, I would like to see this notation unified. If you want to unify the notation with the one with spaces, I will rewrite the PR to that one. Thank you very much for your cooperation.

これはMergeする前に一度記法を決めて置いたうえでMergeした方がいいのですが、Jsonの記述方式としてcolonの前にスペースを入れないのが通例になっています（実際、VSCodeを用いて保存をした際、自動でそう反映されるケースもあります）。 また、今回追加されたMMCの文章においても、この方式で記述されています。

そのため、もし可能であればこの記法に統一してほしいです。 もしスペースを入れる方に統一する場合はそちらにPRを作り直します。よろしくお願いします。

Frooxius commented 3 years ago

I think it is a good idea to not include the space before the colon, I can definitely accept this!

Currently there is a conflict with en.json. Are you able to update it so it doesn't cause a merge conflict on your end?

kazu0617 commented 3 years ago

Currently there is a conflict with en.json. Are you able to update it so it doesn't cause a merge conflict on your end?

Thank you. I have resolved the conflicts so now be able to merge.

Frooxius commented 3 years ago

Thank you very much! Merged!