Neos-Metaverse / NeosPublic

A public issue/wiki only repository for the NeosVR project
195 stars 9 forks source link

IK bone detection issue with right side of an armature #1847

Closed ohzee00 closed 3 years ago

ohzee00 commented 3 years ago

Describe the bug

When importing a model that has a similar structure to Shoulder_Left and Shoulder_Right, UpperLeg_Left and UpperLeg_Right, it will fail to pick up the right parts of the armature, despite the flipped bone names on the left side being detected.

Relevant issues

Don't believe there's been related issues.

To Reproduce

  1. Import NeosthingavatarAFTERBREAKINGfbx located below in the zip file.
  2. Notice that it fails to find the entire right side of the model, despite the naming convention being fine.

Expected behavior

The importer should find the right side of the model and use it for the IK.

Screenshots / Video

Bug information (please complete the following information):

Additional context

Provided in this issue is a example avatar that I could replicate this issue with, I intentionally caused this avatar to follow the naming conventions that another (paid) avatar used that originally caused this issue to crop up.

I was also able to solve this issue by renaming the right side to the convention of ShoulderR, UpperlegR, LowerlegR, etc.. while not touching the other side of the armature(Thanks Shifty!), which seems very strange.

I also provided the original non-naming scheme edited avatar in case that helps at all. (This is also my first time doing a github issue for Neos, my bad for any mistakes or possible misunderstandings)

Reporters:

Shifty#7944, H3BO3#7957 and Turk#2971

ohzee00 commented 3 years ago

Actually I got a correction to my original post (editing it too but want to post a comment) this is in fact a regression from the last build. Importing NeosthingavatarAFTERBREAKINGfbx on 2021.3.12.44 detects the bones correctly.

200Tigersbloxed commented 3 years ago

I was pointed here from the Discord.

This may be relevant to this issue, but I'm not positive. This error can seem to happen when importing Mixamo models as well.

Somewhere around 2020 (Closer to near the end of December), Mixamo rigs worked perfectly fine, but now, when I try to import any Mixamo rig, it will always error missing the following three bones: RightUpperLeg, RightLowerLeg, and RightFoot, even though the bones listed (the ones that should match) are the following: RightUpLeg, RightLeg, and RightFoot.

Attached below is an example of a Mixamo rig failing to be classified as Biped. Note that all the Mixamo rig's error logs look almost identical to each other, so you could just try importing a Mixamo Rig you have if you need to test for yourself.

Apologies if this isn't relevant to this issue, it just seemed similar to the error described in the original issue.

Import Error Log (Mixamo): Content.txt

H3BO3 commented 3 years ago

Any update on this? It's been nearly a month and this issue has affected several users during that time. I would like to know if this has at least been looked into, it'd be nice to know if it's a simple coding/spelling error or something more deep-seated

Frooxius commented 3 years ago

I didn't get to this issue yet, if I did I'd usually post something, but stuff like this I end up fixing once I start looking into this.

H3BO3 commented 3 years ago

@Frooxius Would it be helpful if things like this which seemed like regressions and were affecting multiple new users be tagged as high priority?

Frooxius commented 3 years ago

If it's a widespread and critical issue then yes, it could help those issues stand out, but it's something that only a few people should be able to do, like @shiftyscales. Otherwise if there will be too many "High Priority" issues, none of them will really be.

It might actually help to add "Regression" label, because I usually try to prioritize those when it was a recent change.

Frooxius commented 3 years ago

Should be fixed in 2021.4.14.1059 now, let me know if there are more import issues!