search

Neos-Metaverse / NeosPublic

A public issue/wiki only repository for the NeosVR project
193 stars 9 forks source link

Add "Hue-Shift" masking to Xiexe Toon #2028

Open 3x1t-5tyl3 opened 3 years ago

3x1t-5tyl3 commented 3 years ago

Is your feature request related to a problem? Please describe.

It would allow to hue shift color one part differently than others..

Relevant issues

1951 #1929 #1473 #1928 #1791

Describe the solution you'd like

Add a black-white texture mask as similar issues above which would: Black: No masking. The texture takes control over the color. White: Takes full control over the hue. Anything in-between would be obviously be inbetween. See video below. This would apply to Emission and Albedo textures.

A 0-1 float that would change the hue associated with it.

Obviously with texture scale, transform and all these other options exposed.

Describe alternatives you've considered

Material stacking though that is very limited and costs another render pass (or multiple depending on the shader used)

Additional context

https://user-images.githubusercontent.com/61988002/114921731-2cf57c00-9e2b-11eb-93f2-c674999c4a4b.mp4

Initial request by: @epicEaston197

epicEaston197 commented 2 years ago

Xiexe Toon does not have a Hue-Shift slider to begin with Hue-Shifting is not a property that the material has at the moment so on top of having a slider to do this we need to have a mask for it to do this

3x1t-5tyl3 commented 2 years ago

Xiexe Toon does not have a Hue-Shift slider to begin with Hue-Shifting is not a property that the material has at the moment so on top of having a slider to do this we need to have a mask for it to do this

The video above is literally XiexeToon in unity. Besides you were the one initially asking for it lmao?

epicEaston197 commented 2 years ago

Xiexe Toon does not have a Hue-Shift slider to begin with Hue-Shifting is not a property that the material has at the moment so on top of having a slider to do this we need to have a mask for it to do this

The video above is literally XiexeToon in unity. Besides you were the one initially asking for it lmao?

yeah I know I wasn't saying I was against it I was saying that we need a hue slider

and also it's Poiyomi image

3x1t-5tyl3 commented 2 years ago

It was poyomi as I wasn't able to load Xiexe into unity and got pissed off 2 minutes into it. Especially while you were on my neck in-world about it.

epicEaston197 commented 2 years ago

oh yeah sorry about that

shininghero commented 2 years ago

Looks like the latest version of Xiexe's supports hue shifting now. image