search

Neos-Metaverse / NeosPublic

A public issue/wiki only repository for the NeosVR project
195 stars 9 forks source link

Unable to join Contacts+ session if user is not a contact of the host #2116

Closed shiftyscales closed 3 years ago

shiftyscales commented 3 years ago

Describe the bug

It appears the issue that was to be fixed in 2021.4.27.1385 (- Fixed not being able to join Contacts+ sessions when not friends with the host) still has some unresolved cases. I am unable to join a Hidden, Contacts+ session after receiving an invite from a friend in that session. I am not friends with the host.

To Reproduce

Expected behavior

Connecting to the session should proceed without error.

Bug information (please complete the following information):

Additional context

SHIFTYWINDOWS - 2021.4.28.1415 - 2021-04-28 18_51_03.log A log file from attempting to join such a session in which I launched Neos, attempted to join the session three times, then exited Neos.

Reporters:

Shifty# 7944, jellyosaurus# 7259

Frooxius commented 3 years ago

Fixed in 2021.4.29.1307!

shiftyscales commented 3 years ago

This seems to still be an issue, unfortunately.

Frooxius commented 3 years ago

Can you send me logs from the host?

RaithSphere commented 3 years ago

DIGIPAWS - 2021.4.29.1307 - 2021-05-01 22_17_27.log

shiftyscales commented 3 years ago

And my log attempting to connect to Raith's session, relevant lines starting at 747 onward: SHIFTYWINDOWS - 2021.4.29.1307 - 2021-05-01 11_49_18.log

shadowpanther commented 3 years ago

VIXEN - 2021.4.29.1307 - 2021-05-04 01_35_27.log Encountered this today. Relevant attempts at the end of the log (session name GopStop)

Frooxius commented 3 years ago

Should be fixed for good in 2021.5.4.471, sorry for the trouble!

Readun commented 3 years ago

Saadly... still seeming to be a Problem. Tried it out with xlinka, our Headlesses on Contacts+. We could not join each others headlesses. As soon as I was Contact with the Headless, it worked. Which logs would be relevant? Mine: READUN-PC - 2021.5.4.471 - 2021-05-04 17_43_28.log

Starting at around 17:50:46.870

TehTurk commented 3 years ago

Oh boy. Now question since this has been one of our more prolific bugs, what's been the cause? (Dumb question I know) but how does the discovery of other worlds mixed with join permissions work? It seems like something might have been introduced that's been causing this inherently.

Frooxius commented 3 years ago

The root cause is because we increased the security of the security tokens. This has had a ripple effect on parts of the verification system, including cloud infrastructure.

Security systems like this have a lot of checks along the way, so it's easy to trip them up and fail the process due to mismatch or something unexpected.

It looks like there's some problem with the API part of this now, I'm investigating this.

TehTurk commented 3 years ago

No problem thanks for explaining! I figured an ask on the why/how would be a good idea for most folks to understand what's been going on :)

Frooxius commented 3 years ago

Yeah. This is actually a good example of why we're sometimes resistant to do "small tweaks" that seem really simple on the surface and quick to. Sometimes they have a ripple effect like this, that takes a while to deal with. Sometimes we see those coming, sometimes we don't.

I think I have a solution now that should fixup the problems, working on it now.

Frooxius commented 3 years ago

This has been fixed in 2021.5.5.159!

FroppyVR commented 3 years ago

Just got this, the error said something about being unable to join unless you're contacts with someone in the session, it was contacts+ and I had a few contacts in there. Was a headless run by CytraX.

Logs: DESKTOP-ROAF3GP - 2021.5.8.445 - 2021-05-08 17_44_28.log DESKTOP-ROAF3GP - 2021.5.8.445 - 2021-05-08 17_45_10.log

The second log has the following:

5:54:04 PM.616 ( 39 FPS) Connected to: lnl-nat:///S-f41c751d-8966-42e3-a908-41e5b4730612 5:54:04 PM.622 ( 39 FPS) Waiting for join grant 5:54:06 PM.812 ( 57 FPS) JoinRejected: World.Error.OnlyContactsOfContacts 5:54:06 PM.914 ( 57 FPS) Disconnected: , reason: StopCalled, socketErrorCode: 0 5:54:20 PM.619 ( 39 FPS) SessionInfo. Id: S-f41c751d-8966-42e3-a908-41e5b4730612, Name: Suru Ntal v2.4, URLs: lnl-nat:///S-f41c751d-8966-42e3-a908-41e5b4730612, neos-steam://76561199093449832/8/S-f41c751d-8966-42e3-a908-41e5b4730612

Frooxius commented 3 years ago

Is it possible to get logs from the host for this session?

shiftyscales commented 3 years ago

I've asked that people provide them. From the cases I've heard people mention of this issue occurring, it sounds like if they try rejoining enough times, they are eventually let in. Not certain if knowing that helps at all, Froox.

I believe we're currently awaiting logs from Raith.

AshtonSparx commented 3 years ago

DESKTOP-SPEUN1P - 2021.5.6.453 - 2021-05-07 16_58_20.log Line 943 is first attempt (in my logs)

RaithSphere commented 3 years ago

This log is huge [CYTRAX - 2021.5.5.159 - 2021-05-05 04_02_28.log](https://github.com/Neos-Metaverse/NeosPublic/files/6446688/CYTRAX.-.2021.5.5.159.-.2021-05-05.04_02_28.log)

Frooxius commented 3 years ago

Thanks for the logs, found the issue! Was due to some token symbols not being encoded properly, should be working properly in 2021.5.9.179 now! (the joining user needs to update, not just the host!)