Neos-Metaverse / NeosPublic

A public issue/wiki only repository for the NeosVR project
195 stars 9 forks source link

Folder importer breaks UIX rendering for user who starts the import #2273

Open Elektrospy opened 3 years ago

Elektrospy commented 3 years ago

Describe the bug

If you try to batch import more than ~11 3d model files, using the folder importer dialog, it breaks the UIX rendering for the person starting the batch import.

Relevant issues

not that i am aware of

To Reproduce

  1. Drag'n drop the folder with multiple 3d model files into the NeosVR window or use the folder/multi import icon 1.1 or use the folder/multi import icon on the file browser on the file browser
  2. no need for any specific settings, just get to the import (now) button and press it
  3. if you see black quads instead of the loading circles, its broken on your side

Expected behavior

have the normal batch import behavior as you would do grabbing a folder with 10 (or less files) or directly only dragging the files into neos.

Log Files

The log files actually do not contain anything regarding the issue :(

Screenshots / Video

neosvr_bug_folder_importer_000

Bug information (please complete the following information):

Additional context

It only breaks for the person who does the batch import, everyone else in the session will just get the normal loading circles and you will get the generated empty object for the "soon to be imported" 3d models.

Drag'n dropping the multiple 3d files directly into neos does work, as long as you don't get the batch dialog window.

We tested it with .obj, .fbx and .glb / .gltf files.

Reporters:

Elektrospy, 3x1t_5tyl3, marsmaantje

Frooxius commented 3 years ago

Thanks for report, this is a known issue, the background processes get overloaded which freeze the updating. It requires the importer code to be reworked a fair bit to address. For now I recommend importing models in smaller batches.

MartnDe commented 3 years ago

Even when the Neos Logo is still turning as it is importing if you use more then ten it freeze :) I tried it with several amounts :) up to 300 as I wanted to import a PLY volumetric Streaming sequence :) ... that is a example use case for the folder importer. It would be interesting or a nice option to have if the importer should import all at once or one model after the other with the same XYZ position for Streaming Assets for volumetric film assets it would be very helpful.

IanCorvid commented 3 years ago

I'm unsure why, but this issue seems to be getting worse. Today I've been able to repeatedly reproduce this UIX crash when attempting to upload 6 or more 3D object files. I was able to upload 6 OBJ files, but it crashed again when I attempted 10.