search

Neos-Metaverse / NeosPublic

A public issue/wiki only repository for the NeosVR project
197 stars 9 forks source link

Unreliable VRIK Ground Detection on Some Avatars #2350

Open Enverex opened 3 years ago

Enverex commented 3 years ago

Describe the bug

Avatars when imported sometimes have their feet go up into the air BUT act normal when being held (their feet will "walk" on the ground as expected). I've noticed a possibly related issue where when toggling VRIK, it simply won't detect the floor a majority of the time, but will eventually if you keep grabbing and ungrabbing the model. What makes this even more confusing is that it's local, so while it may look broken for one person it may look OK for someone else and then after repositioning it, it may then be fixed for you but now broken for other people.

Relevant issues

Not finding any.

To Reproduce

  1. Spawn a problematic model.
  2. Move it around.
  3. The legs will randomly snap upwards, but the IK will work properly when the avatar is moved across the ground (e.g. it will wall correctly). Letting go of the avatar may result in the legs snapping back up, other times (seemingly randomly) it will correctly stay on the ground.

Expected behavior

For the legs to "dangle" when in the air, or clamp to the ground if within reach.

Log Files

Nothing logged.

Screenshots / Video

In this video, you can see that every time I grab the model, the feet correctly snap to the ground, but when I let go, it normally goes back to the inverted/upwards position. After enough repeated and release grabs, the feet stay in the correct position (for now, until the IK is disabled then reenabled, then it's back to pot-luck). https://youtu.be/r7r_ZfeCedM

Bug information (please complete the following information):

Additional context

I've seen people have this issue with random avatars on import. Nothing looked obviously wrong with their bones, positions, configuration, etc.

Frooxius commented 3 years ago

Can you send me a reproduction model please? We generally can't do much about issues like this without a sample to reproduce the problem.

Enverex commented 3 years ago

If you open this public folder (neosrec:///U-Enverex/R-39c1584b-436f-45ae-966b-3ef51ba8d667) then go into "Cat Band (KMB)" the "KMB Chromatic Avatar" exhibits the issue. It seems the fix on this specific model is changing the GroundCheckHeightRatio value from the default of 0.35 to 0.1. I'm not sure if that's actually the correct way to fix it, or simply works around the problem.