Neos-Metaverse / NeosPublic

A public issue/wiki only repository for the NeosVR project
194 stars 9 forks source link

Add animation import/better animation support #2769

Open jonnyawsom3 opened 3 years ago

jonnyawsom3 commented 3 years ago

Is your feature request related to a problem? Please describe.

(As a heads up, there may be workarounds or I've missed something, but at the time of writing this is all I know) Currently there's no way to import a standalone animation file for a model (Such as BVH or ANIM files), you have to import the entire model to get the single file you want, and then repeat for every one (And even then I'm not sure how to select what animation it will import).

Relevant issues

No response

Describe the solution you'd like

Ideally Neos could convert other animation files into the animx files that it uses, letting it be done much faster especially in bulk. Then also an exporter as I'm not sure what programs accept animx

Describe alternatives you've considered

I suppose you could import an FBX every time, however then you need to use the inspector to find the animation file, and afterwards delete the rest

Additional context

No response

Frooxius commented 3 years ago

What happens when you try to import BVH files? Those are already supported (Assimp supports those) and have been successfully imported in the past. There might be some issue with the ones you're trying to import, providing samples can help.

I'd advise against using animx directly. It's Neos' internal format and it's not designed for interoperability. It needs to be paired with other information to work properly.

jonnyawsom3 commented 3 years ago

When I said about using animx, I meant automatically converting more filetypes to it, although I realise it could be a pain extending Assimp. I'm currently on my phone but I'll try importing them again/uploading samples once my computer is on.

Frooxius commented 3 years ago

As I mentioned in my post, Assimp already supports BVH and so does Neos by proxy, there is no need to extend it.

It sounds more like you ran into a bug or some strange issue that caused a problem during import, but we'd need more info on that.

jonnyawsom3 commented 3 years ago

image I don't see an option which suggests it would be for an animation file, and when I just managed to get it in after choosing model and waiting a minute or two, it's not very clear how to add it to a model (I had an animation which rotated the hip bone, I added the animation component to the body of my avatar and plugged in the hip rotation, then nothing happened). If it ends up me missing something again then I'll start doing a lot more testing before making issues, but I would've thought playing an animation made for a model would be practically drag and drop onto it seeing as it would already use the same bones.

Electronus commented 3 years ago

You cant animate bones that are already driven, for example the hip bones of an avatar.

Anything that isn't driven though? Its just fine! and yeah its plug animation into animator and there is a button to assign from names. (must be on the object to be animated)