Neos-Metaverse / NeosPublic

A public issue/wiki only repository for the NeosVR project
195 stars 9 forks source link

Importing a .pmx model with national characters in file path fails with an exception #3036

Closed shadowpanther closed 5 months ago

shadowpanther commented 3 years ago

Describe the bug?

When trying to import a .pmx model with file placed into a folder that contains national (Russian in this case) symbols in the path, Assimp fails to import the model with the following exception:

15:19:30.293 ( 60 FPS)  Importing files with Asset Class Model:
D:\rrrde\Загрузки\!MODELS\Tanuki_v1.0\raccoon_girl.pmx
15:19:38.711 ( 62 FPS)  Exception when importing D:\rrrde\Загрузки\!MODELS\Tanuki_v1.0\raccoon_girl.pmx:

Assimp.AssimpException: Error importing file: Failed to open file D:\rrrde\Загрузки\!MODELS\Tanuki_v1.0\raccoon_girl.pmx.
  at Assimp.AssimpContext.ImportFile (System.String file, Assimp.PostProcessSteps postProcessFlags) [0x00084] in <2bbd770ad2e943ec9a89007d8dfbcb77>:0 
  at FrooxEngine.ModelImporter+<ImportModel>d__6.MoveNext () [0x006c2] in <37c1b9afea074aa2a9d4fa3ffc975415>:0 

Relevant issues

None found

To Reproduce

Try to import a .pmx file placed in a folder with national characters in the name/path. It is currently unknown what characters in particular cause this.

Expected behavior

Model imports as usual

Log Files

log from demonzla

Screenshots

No response

How often does it happen?

Always

Does the bug persist after restarting Neos?

Yes

Neos Version Number

2021.9.16.105

What Platforms does this occur on?

Windows

Link to Reproduction Item/World

No response

Did this work before?

I Don't Know

If it worked before, on which build?

No response

Additional context

No response

Reporters

demonzla#4135

jeanahelver commented 3 years ago

is it only happening for pmx models? could you try fbx/obj.

shadowpanther commented 3 years ago

gltf, blend and fbx seem to load just fine, that's why I mentioned pmx in the report.

Frooxius commented 3 years ago

Do you have any sample file I could test with? I'm updating Assimp to latest version in the next build, but I can't verify if that helps so you'll have to check yourself. Otherwise we'll have to report this directly to Assimp to fix on their end.

demonzla commented 3 years ago

here two sample models in pmx 1.zip

Frooxius commented 3 years ago

Thanks! I've released latest Assimp in 2021.9.20.1334, but it doesn't seem like it fixes this issue. This means we'd have to make a report upstream.

Would anyone be willing to help with this? Alternatively anyone can implement a fix for this too if they can. Here's our fork for reference: https://github.com/Neos-Metaverse/assimp