search

Neos-Metaverse / NeosPublic

A public issue/wiki only repository for the NeosVR project
195 stars 9 forks source link

Models that import with Hip bone named "Hip" vs "Hips" fail to register the Hip Bone #3057

Open TehTurk opened 3 years ago

TehTurk commented 3 years ago

Describe the bug?

Was helping a user figure out why they were having issues with a model. Turns out it wasn't detecting/assigning the Hip properly and the spine and chest bones were knocked down to "hip" and "spine" assignments respectively in the hierarchy trying to auto-setup the IK.

If the hip bone is named Hip, it won't register, if it's Hips it'll import properly.

Relevant issues

2800 Possibly related?

To Reproduce

  1. Import a model with hips works fine
  2. Going into Blender, rename the hip bone to be hip
  3. Watch as the importer fails to recognize the model importing.

Expected behavior

Detecting of Hip bone as Hips. I understand the need for rig requirements schemes to be strictly followed, but adding "Hip" as a name schema to the checks wouldn't hurt. That or check if bones are plural or singular.

Log Files

There is none that detect this occurring.

Screenshots

https://i.imgur.com/138KvTn.jpeg

How often does it happen?

Always

Does the bug persist after restarting Neos?

Yes

Neos Version Number

Current

What Platforms does this occur on?

Windows, Linux, Android / Quest

Link to Reproduction Item/World

No response

Did this work before?

No

If it worked before, on which build?

No response

Additional context

No response

Reporters

Turk, AngriestSCV, H3BO3# 7957

shiftyscales commented 2 years ago

Added this as a card on the priority and triage board: https://github.com/Neos-Metaverse/NeosPublic/projects/23#card-71330260

Cataena had discovered this issue on an avatar she was importing, she then also recreated this issue on my request by taking a known working avatar, and changing the 'hips' bone to be labelled as 'hip', with no other changes to the armature

The reverse was also tested- fixing the detection by modifying the armature of the broken model by changing the hip bone to be named hips.

I've requested she upload the sample model here.

Cataena commented 2 years ago

mannequin hip.zip

H3BO3 commented 2 years ago

Isn't this a duplicate of #2025?

shiftyscales commented 2 years ago

It would appear so- but since this issue has more activity, a sample model, and Prime's assignment on it, it may be pertinent to close your orignal issue instead, @H3BO3. I'll do that, and have added you as a reporter on this issue.