search

Neos-Metaverse / NeosPublic

A public issue/wiki only repository for the NeosVR project
195 stars 9 forks source link

Neos doesn't close properly if you've opened OBS from within Neos #314

Open ProbablePrime opened 5 years ago

ProbablePrime commented 5 years ago

Recently Steam has been registering Neos as being open long after the actual neos window has closed.

This leads to a full restart of Steam being required before the game can be ran again. A view of task manager shows that Neos.exe is not running.

Let me know how I can help debugging this :)

Frooxius commented 5 years ago

I'm not sure what I could do about this one, it seems like a Steam bug. Neos calls Steam API shutdown when it exits, but after that I can't really do much unless there's something I'm missing.

ProbablePrime commented 5 years ago

I'll check my logs the next time this happens to see if there's any hint of an unclean exit. thanks. i get these are hard to look at :)

sirkitree commented 4 years ago

Please reopen if you're still having this issue. There have been no other reports that I'm aware of.

shiftyscales commented 4 years ago

I actually know a very likely cause for this, and I believe it is a Steam issue more than a Neos one. If you launch OBS using the websocket, even after you've closed Neos, Steam reports Neos as running until you also exit out of OBS, likely because Steam has hooked itself into the OBS process as it was called/open from Neos.

ProbablePrime commented 4 years ago

Wow that is it. Of course. I have OBS open most of the time to make tutorials!

sirkitree commented 4 years ago

Interesting, I have OBS open all the time too but do not run into this problem, even if I've connected with websocket

Anomalous commented 4 years ago

@sirkitree Are you just connecting to OBS or are you launching OBS from within Neos?

It sounds like if you launch OBS from Neos then OBS is a child process of the Neos process, and of course Neos wouldn't be considered closed until all of its child processes are closed also. Nothing specific to OBS or the websocket connection.

ProbablePrime commented 4 years ago

Can confirm this is what im doing, I dont want to launch obs until i actually need it and the launch mode is very convenient. If this is the case looking at launching it in a slightly different manner might resolve this.

sirkitree commented 4 years ago

Ah, yes. I typically launch it separately.

shiftyscales commented 4 years ago

There's not a lot of point on re-opening this, @sirkitree. The issue is on Steam's end, and I'm pretty sure it's intended behavior. E.g. for games with launchers. It's just a quirk of how it works.

The only real way around it would be to have Neos force-quit child processes like OBS when the game is exited, which probably isn't a desirable behavior, and just sounds kind of hacky in general assuming it could be done.

ProbablePrime commented 4 years ago

Shifty, it should be possible to alter the method that neos opens OBS to prevent this. At least in the world of linux this is something that comes up when spawning child processes from time to time.

shiftyscales commented 4 years ago

It could very well be the case. If that's true, it would be nice to see it fixed/changed. At least for the short-term we know the cause, and how to work around it, though.