Neos-Metaverse / NeosPublic

A public issue/wiki only repository for the NeosVR project
195 stars 9 forks source link

Slerp_floatQ default value produces unexpected behavior #3294

Open Nordwig opened 2 years ago

Nordwig commented 2 years ago

Describe the bug?

When using a Slerp_floatQ logix node leaving the first input open prevents the node from outputting a "valid" rotation to drive a slots rotation while "Lerp Value" is between 0 and 0.7. When the Lerp value reaches 0.8 the output starts to be "valid" and the target slot is rotated. Which results in a jump instead of a transition between the inputs. If you connect input note to the open input it starts to work as expected. Also connecting a unchanged ValueRegister validates the output. It seams the default Value is X,Y,Z,W->0,0,0,0 while Input_node and "ValueRegister" are X,Y,Z,W->0,0,0,1

I think the default Value should be X,Y,Z,W->0,0,0,1

MultiSlerp suffers the same problem. lerp_floatQ and MultiLerp_floatQ also not working probably with an open Input just switching the value when "Lerp Value" > 0 .

Relevant issues

I have seen it often in logix when u want a value to be 0 just to leave the input open and it normally works as expected. Or the default is set to a value that prevents things from getting confusing like the "Mul_Float" is set to 1 which is nice for debugging.

Using this approach with the "Slerp_floatQ" delivers unexpected results

To Reproduce

Set up a Slerp_floatQ, input "From" open input "To" with a random rotation ( X ) and drive the output to a rotation of a slot.

Expected behavior

When the Lerp_Value increases from 0 to 1 the Rotation should transition between 0 and (X)

Log Files

No response

Screenshots

Photo in Slerp Test World1

How often does it happen?

Always

Does the bug persist after restarting Neos?

Yes

Neos Version Number

2021.10.30.605

What Platforms does this occur on?

Windows

Link to Reproduction Item/World

neosrec:///U-Nordwick/R-d6047a9f-98b1-4eb4-903e-5f70af297068

Did this work before?

I Don't Know

If it worked before, on which build?

No response

Additional context

No response

Reporters

Nordwick, KyuubiYoru, Jackson

epicEaston197 commented 2 years ago

the same thing happens with tween leaving the input open does not make it tween https://www.youtube.com/watch?v=1FczvnqsaKA