Neos-Metaverse / NeosPublic

A public issue/wiki only repository for the NeosVR project
197 stars 9 forks source link

importing a BSP file crashes NEOS instantly #3583

Open epicEaston197 opened 2 years ago

epicEaston197 commented 2 years ago

Describe the bug?

I was wanting to import maps from The Stanley Parable but when i drag a map in it spawns in the model importer and going through the dialog result in the model not being imported and my game crashes instantly image

Relevant issues

nothing

To Reproduce

get a BSP file and attempt to import it image

Expected behavior

the models should import with no problems and won't crash my game instantly

Log Files

DESKTOP-DAN95E7 - 2022.1.28.1335 - 2022-02-05 08_15_44.log

Screenshots

No response

How often does it happen?

Always

Does the bug persist after restarting Neos?

Yes

Neos Version Number

2022.1.28.1335

What Platforms does this occur on?

Windows

Link to Reproduction Item/World

no response

Did this work before?

No

If it worked before, on which build?

this did not work before to my knowledge

Additional context

BSP is not filetype type that GitHub supports

Reporters

@epicEaston197

shadowpanther commented 2 years ago

Uh.. does assimp even support BSP format? https://github.com/assimp/assimp/blob/master/doc/Fileformats.md

epicEaston197 commented 2 years ago

I don't know with most 3D model types that are not supported by NEOS they won't actually bring up a dialogue instead it will display the Raw file but importing a BSP does not result in the Raw file being displayed

Uh.. does assimp even support BSP format? https://github.com/assimp/assimp/blob/master/doc/Fileformats.md

epicEaston197 commented 2 years ago

Uh.. does assimp even support BSP format? https://github.com/assimp/assimp/blob/master/doc/Fileformats.md

this might be an explanation of why it is supposed to support that I think https://github.com/assimp/assimp/issues/1030

shadowpanther commented 2 years ago

Actually, the initialization line in the log (line 26) reports that bsp is indeed supported, but I'm not sure whether that list is from the assimp itself or hardcoded into the Neos's part of the wrapper.

epicEaston197 commented 2 years ago

so BSP is supported it's grouped up with file types that import fine so I'm assuming this is a bug image

shadowpanther commented 2 years ago

But BSP is.. not one format. BSP is the name for the spatial data structure - Binary Space Partitioning. It goes back at least to Duke3D times. And then we have this: https://github.com/assimp/assimp/issues/2996

epicEaston197 commented 2 years ago

But BSP is.. not one format. BSP is the name for the spatial data structure - Binary Space Partitioning. It goes back at least to Duke3D times. And then we have this: assimp/assimp#2996

that was made two years ago maybe you can add waiting on "Third party" Tag

iamgreaser commented 2 years ago

It goes back at least to Duke3D times.

Oddly enough, Duke3D itself doesn't do BSP, but this is still correct. Doom used it, although its maps didn't actually have any file extensions, but were split into several subfiles inside a *.wad archive.

Anyway, *.bsp tends to refer to stuff descended from the Quake 1 map format, but these descendents are typically incompatible with each other.

Except of course there were other games which used BSP but the formats are completely different, and some even have a *.bsp file extension, e.g. Tony Hawk's Pro Skater 3 (which is possibly the only game in the series to store levels using a BSP).

It would be worth elaborating on which forms of the BSP format are supported here - e.g. actually explicitly saying "bsp (Quake 3)", "bsp (Source v20)"

But of course, it should never crash the game.

epicEaston197 commented 2 years ago

in my opinion I should be able to drag-and-drop any bsp file and have it automatically import there is a blender plugin that does exactly what I'm describing https://github.com/REDxEYE/SourceIO