Neos-Metaverse / NeosPublic

A public issue/wiki only repository for the NeosVR project
196 stars 9 forks source link

Implement MP3 format #3896

Open epicEaston197 opened 1 year ago

epicEaston197 commented 1 year ago

Is your feature request related to a problem? Please describe.

The patents for MP3 have long since been expired (since 2012) so I see no issue with implementing MP3 into neos as a standard audio format

Relevant issues

3840

Describe the solution you'd like

When I import a MP3 either remotely or from my computer it should work and be converted into an audio player similar to ogg

Describe alternatives you've considered

None really unless you want to download the audio and convert it yourself which in some cases like contacting an API it's not possible unless you want to contact a middleman server

Additional context

sorry if this is a duplicate of another issue but I just found out that the patents for MP3 expired

shiftyscales commented 1 year ago

Frooxius had last attempted to resolve this issue in October of 2021. He is looking to use the NLayer decoder. https://github.com/naudio/NLayer

There's also some other libraries that we got to revisit, but they didn't yield any results 😦 E.g. with the CSCore, I saw that the NLayer (for decoding MP3 natively) had a bunch of updates, but it's still too unstable - it'll just randomly stop playback.

But it's good that it's moving, it means at some point it might be mature enough for our usecase: https://github.com/naudio/NLayer

https://discord.com/channels/402159838827905024/731903736028332083/900539820462465044