Neos-Metaverse / NeosPublic

A public issue/wiki only repository for the NeosVR project
195 stars 9 forks source link

attempting to save the default avatar will cause your head to become lost #725

Open mralext20 opened 4 years ago

mralext20 commented 4 years ago

repro:

unfavorite your avatar respawn be headset and hands hit the blue download button to save the default avatar become a voiseless set of hands

shiftyscales commented 4 years ago

This is technically correct behavior as the Headset has the AvatarDestroyonDequip component which destroys the avatar when you leave it so you don't leave an empty avatar behind when switching into a new one (and you are momentarily dequipped from the avatar during the avatar saving process.)

shiftyscales commented 4 years ago

It is something that could be looked at/addressed in a variety of different means.

E.g. other users have noted wanting to leave the avatar they've entered/go back to the default avatar (thereby, saving a copy of the default avatar wouldn't be necessary/that function could be disabled if you aren't in a saveable avatar).

Others have also suggested the default avatar could be different too- something neutral- but with more personality/flair than the floating VR headset.

Frooxius commented 4 years ago

One way to solve this would be to just disallow saving the default avatar. The default one is specifically made to cleanup itself when you exit it.

Alternatively that behavior could be removed, since it gets cleaned up anyway in most cases (such as on hot-swap), so that could be solution too. Originally you'd typically swap to another avatar in-world from the default one, but most behaviors will now actually cleanup the avatar. The only cases would be when a new user joins in and somebody gives them the avatar in-world, which would leave the headset behind.

shiftyscales commented 4 years ago

In that case, I think that'd be a preferable behavior that the default avatar is treated more like a standard avatar with no real behavior changes to it compared to a regular avatar.

Frooxius commented 4 years ago

Hmm, I tried to make the change, but it's getting more complicated, the default headset avatar isn't really fully setup as full avatar, so when it's not destroyed, it just gets stuck in the world, not really usable. I'll have to shelve this for later.

shiftyscales commented 2 years ago

I took a moment to re-evaluate this. Since the content building team can now submit tweaks to the default head and hands avatars, it is technically possible to address this issue from that end- the only thing that can't currently be done is ensuring the VR headset doesn't get marked as non-persistent, but that could be mitigated by using Logix to set it as persistent on loaded, @Earthmark, and after being saved, the avatar functions as any other head and hands.

Although a more native solution would probably still require reworking/tweaking some things.