Neoteroi / rodi

Implementation of dependency injection for Python 3
MIT License
179 stars 17 forks source link

style: added typehints to GetServiceContext init params #25

Closed guscardvs closed 1 year ago

guscardvs commented 1 year ago

https://github.com/Neoteroi/rodi/issues/24

Added type hints based on discussion in this issue. I ran the tests and the format routines and everything went ok

codecov-commenter commented 1 year ago

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (2a54a21) compared to base (a8cc027). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #25 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 1 1 Lines 522 522 ========================================= Hits 522 522 ``` | [Impacted Files](https://codecov.io/gh/Neoteroi/rodi/pull/25?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Neoteroi) | Coverage Δ | | |---|---|---| | [rodi/\_\_init\_\_.py](https://codecov.io/gh/Neoteroi/rodi/pull/25/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Neoteroi#diff-cm9kaS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Neoteroi). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Neoteroi)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

RobertoPrevato commented 1 year ago

Hi @guscardvs, thank you for your contribution! I'm merging now. By the way, I want to publish an updated package to PyPi during the weekend, so your contribution should be available soon in PyPi. PS. I will remove the .python-version file later.

guscardvs commented 1 year ago

Hi @RobertoPrevato, you're welcome, the file was left because of my pyenv, 😄 , thank you.