search

Neoteroi / rodi

Implementation of dependency injection for Python 3
MIT License
174 stars 17 forks source link

🐛 fix: allow factory method to get requested type as well as activating type #54

Open StummeJ opened 6 months ago

StummeJ commented 6 months ago

This fixes issue #53

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.82%. Comparing base (f6d6fbc) to head (1a13acc).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #54 +/- ## ======================================= Coverage 99.82% 99.82% ======================================= Files 2 2 Lines 565 574 +9 ======================================= + Hits 564 573 +9 Misses 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

RobertoPrevato commented 5 months ago

Hi @StummeJ Thank You for your contribution, and sorry for not replying earlier. I reviewed this weekend.

I tried to understand the use case for supporting this scenario, but I don't get the rationale for it. Can you please give a more realistic example?