search

NeotokyoRebuild / neo

NEOTOKYO Rebuild - Source SDK 2013 mod of NEOTOKYO
https://neotokyorebuild.github.io/
Other
23 stars 12 forks source link

All chat text has a default color tag, leading to no coloration bleed from previous messages being colored #298

Closed blaberry closed 3 months ago

blaberry commented 5 months ago

The chat colors are sometimes bugged (colors from previous chat messages apply to next ones, probably need to set color tags for text that doesn't have em, which makes them get colored by previous text). - Wakfu

nullsystem commented 4 months ago

Give reproducible example steps.

blaberry commented 4 months ago

Not sure what leads to it happening, but here's an example

Image

blaberry commented 4 months ago

Another example, might be separate issues.

Image

blaberry commented 3 months ago

No obvious way of reproducing this.

AdamTadeusz commented 3 months ago

I think its connected to fake nicknames, I can reproduce it by using the single character 'a' as my fake nickname but not other single characters image

AdamTadeusz commented 3 months ago

image Also here is another one. Easy to see what is going on now (this might not be the only issue, since this shouldn't have broken @blaberry 's second example)

(Edit) maybe at the time of that second example it was still looking for the player's original name instead of the fake nickname. Since mzync was nowhere in that message (I'm assuming 2013 year of linux dekstop is mzync), it didnt know where to stop colouring so returned early

(Edit 2) Another example to really hammer the problem home image An easy solution would be to look for the combination of the player name and the ":" character, since this character does not exist in any team tag or the DEAD tag, although this might still fail once we add clan tags or location tags

(Edit 3 (I don't like to spam the discord updates)) If kinoko's steam name was just kino and she changed her fake nick to the longer kinoko I guess that would have explained the first example too