NeotokyoRebuild / neo

NEOTOKYO Rebuild - Source SDK 2013 mod of NEOTOKYO
Other
11 stars 9 forks source link

Generate build date + hash to the main menu and neo_version on building the project #349

Closed nullsystem closed 1 month ago

nullsystem commented 1 month ago

neo_version and neo_sv_version commands example:

] rcon neo_version 
neo_version (Server's build info):
Build version: 20240612_97851598
Build datetime: 2024-06-12T21:48:32Z
Git hash: 978515989cf331f439596e0d7fb23c2a1f8e9d98
OS: Windows
Compiler: MSVC 19.39.33523.0
] neo_version 
neo_version (Client's build info):
Build version: 20240612_97851598
Build datetime: 2024-06-12T21:48:32Z
Git hash: 978515989cf331f439596e0d7fb23c2a1f8e9d98
OS: Windows
Compiler: MSVC 19.39.33523.0
nullsystem commented 1 month ago

@Rainyan That's kinda neat, will look into this along-side issue/PR templates which I've filed in here: https://github.com/NeotokyoRebuild/neo/issues/350 I think I'll be looking in the GH template stuff soon anyway.

EDIT: Some info regarding URL and templates here: https://github.com/NeotokyoRebuild/neo/pull/351#issuecomment-2156496019

Rainyan commented 1 month ago

Should we also add a console command for server side (and maybe client too)? This would help users with verifying SRCDS version, especially. neo_version or something?

nullsystem commented 1 month ago

Should we also add a console command for server side (and maybe client too)? This would help users with verifying SRCDS version, especially. neo_version or something?

@Rainyan Yeah I was kind of thinking of that actually, maybe throw in some extra info like OS and what compiler the build is built on.

Rainyan commented 1 month ago

@Rainyan Yeah I was kind of thinking of that actually, maybe throw in some extra info like OS and what compiler the build is built on.

That seems useful too.

Rainyan commented 1 month ago

How would you feel about adding a small and simple git hash above the player status box:

sha

This could help with recognizing a build from a screenshot or video, if for whatever reason there's no version info provided with it.

I could push this as a commit into this PR (once you're done with your own changes), if you're ok with it. It's just a hacky offset text draw above the HUD element.

nullsystem commented 1 month ago

How would you feel about adding a small and simple git hash above the player status box:

sha

This could help with recognizing a build from a screenshot or video, if for whatever reason there's no version info provided with it.

I could push this as a commit into this PR (once you're done with your own changes), if you're ok with it. It's just a hacky offset text draw above the HUD element.

@Rainyan I'm fine with it, you can go ahead and push the HUD text changes commits.

Rainyan commented 1 month ago

Also, I'm done pushing to the PR, so feel free to push stuff after pulling my edit and hopefully it shouldn't conflict.