NeotokyoRebuild / neo

NEOTOKYO Rebuild - Source SDK 2013 mod of NEOTOKYO
Other
9 stars 9 forks source link

[BUG] Class can be changed freely in an empty server #415

Open kassibuss opened 4 days ago

kassibuss commented 4 days ago

Build Info

Build datetime: 2024-06-29T16:37:06Z Git hash: 96f57bed41f9607377521292c952d691696270d0

Description

Currently, when you join an empty server, spawn in and open the class selection menu, the class will change instantly to the one you pick. This is not how it is in the current iteration of Neotokyo. In that, selecting a class while you are will not result in your class changing instantly.

To Reproduce

  1. Join an empty server
  2. Join a team
  3. Spawn in
  4. Open the class selection menu (F2)
  5. Select any of the classes

Expected behavior

Your class will not change whilst you are alive

Actual behavior

Your class changes when you pick a class that is not the same as your current class

Operating System

Version/Distro

10

Machine's CPU

No response

Machine's GPU

No response

GPU's driver

No response

Build's compiler

No response

Additional context and Screenshots

No response

Rainyan commented 4 days ago

While not parity, being able to undo incorrect class picks feels like an upgrade. Although I suppose we could add a cvar for stricter behaviour. We already have sv_neo_can_change_classes_anytime which could maybe be repurposed to accept more enumerations (and default to parity behaviour)?