search

NeotomaDB / api_nodetest

node.js and express implementation for the Neotoma API
MIT License
2 stars 0 forks source link

Cross reference pub ID's with old Neotoma API (some may be missing) #65

Closed jpjenk closed 6 years ago

jpjenk commented 6 years ago

Example cases:

http://api.neotomadb.org/v1/data/publications?pubid=1412

http://api-dev.neotomadb.org/v2.0/data/publications?pubid=1412

Empty return for new API so something is suspicious here.

SimonGoring commented 6 years ago

There is a different way of doing this: http://api.neotomadb.org/v1/data/publications/1412

The other method should work, but for some reason the publication 1412 isn't working, and I'm not sure why.

SimonGoring commented 6 years ago

Okay, it was a problem with the default query, some of the publications (and 1412 for example) are not associated with datasets explicitly, so the inner join failed.

https://github.com/NeotomaDB/api_nodetest/commit/e84b236594c1aaf2cc6c83dc47137cbe70a34228

SimonGoring commented 6 years ago

Fixed with Pull Request #67