search

NeowayLabs / neosearch

Full Text Search Library
30 stars 4 forks source link

[CHANGE] Change project structure. Closes #19 #21

Closed i4ki closed 9 years ago

i4ki commented 9 years ago

@katcipis Take a look!

What do you think?

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 52.38% when pulling 223bddb8610a4f6891ae1fdbafd8b0d02e81117d on tiago4orion:fix-project-structure into 5fd2b8ad838f6c3e0fd2229178e8611514b90c6a on NeowayLabs:master.

katcipis commented 9 years ago

I think it is great :D. The only problem is why does make all and make library only produces the library directory on the bundles ? Doesn't Go libraries produce a *.a" file ?

katcipis commented 9 years ago

The master is also not producing anything inside of bundles... Is this normal ? :P (first Go library lol, I remember reading about a .a file...but Im not sure anymorel)

i4ki commented 9 years ago

you are right! I haven't verified that.

using go build -o "$DEST/neosearch.a" should create an archive (ar) file representing the entire package. You can verify with "ar t $DEST/neosearch.a"

I will fix that.

i4ki commented 9 years ago

but... What is the relevance of "make library"? Who will use that command?

When you build a library without the "-o" option, the go command tool will generate the ar files inside the $GOPATH/pkg.

I guess that we can drop the option "make library". Do you agree?

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 52.38% when pulling 992685a70b5c73b2f59f8b49f45c722cb9aab960 on tiago4orion:fix-project-structure into 5fd2b8ad838f6c3e0fd2229178e8611514b90c6a on NeowayLabs:master.

katcipis commented 9 years ago

I agree to drop make library