NeowayLabs / neosearch

Full Text Search Library
30 stars 4 forks source link

Added one more batch test for multiple writes #39

Closed ppizarro closed 9 years ago

i4ki commented 9 years ago

The tests did not pass because of an ugly dependency on file system on our tests today. I fix your tests in commit c9df700f665b74a30996d32c29110137af33b234 simply using a diferent db name for the multi-batch test.

I didnt have time to dig a little further into this, but apparently each Go test run in a separate goroutine, so even if you create and destroy the database directory and files associated with the test in your Test* func, you will end with race condition between test funcs if they re-use the same file and directory names. https://github.com/golang/go/blob/master/src/testing/testing.go#L561

The issue #6 created by @katcipis is related to that filesystem dependencies in neosearch tests. Yes, it sucks... I'd saw some implementations of filesystem interface to able mock the FS in golang, but in your case the FS stuff is done by third-party library (leveldb).

[]'s