fix: avoid dup key press on windows

Neptune-Crypto / neptune-core

anonymous peer-to-peer cash

Apache License 2.0

23 stars 7 forks source link

fix: avoid dup key press on windows #66

Closed dan-da closed 2 months ago

dan-da commented 9 months ago

Addresses #65

Windows sends two separate key events for each key: KeyEventKind::Press and KeyEventKind::Release

Before processing a key event, we ensure it is a Press thereby ignoring Release events

Testing performed:

I ran the dashboard on linux and verified that the keys still work in all the screens.
I have NOT tested on windows yet.

I am making this a draft PR until it can be tested on Windows. I have a laptop with windows on it, but don't have rust toolchain installed yet.

Sword-Smith commented 6 months ago

I cherry-picked 26497122521d204e9d33bb0565badb051d99f347 and pushed it to master, and it improved dashboard support on Windows, but the send/receive screens unfortunately don't work on Windows. Once you leave the dashboard and go to the terminal to copy/paste addresses, you cannot return.

dan-da commented 2 months ago

this was merged in dfde0e521bf3093ad98775516f2148c520946668, though #65 remains open, I think due to https://github.com/Neptune-Crypto/neptune-core/pull/66#issuecomment-1876770183. closing.