Thv/remove leaf idx from mmr mp

Neptune-Crypto / twenty-first

Collection of mathematics routines and cryptography for the twenty-first century

GNU General Public License v2.0

74 stars 22 forks source link

Thv/remove leaf idx from mmr mp #219

Closed Sword-Smith closed 4 months ago

Sword-Smith commented 5 months ago

Remove leaf-index from MMR's MmrMembershipProof
Add struct LeafMutation for encapsulating the data required to mutate a leaf in an MMR-accumulator
Change return type of archival-version of MMR (here called MockMmr) to only return an MMR membership proof, not the membership proof, and the peaks
change MMR trait method name from get_peaks to peaks
change MMR trait method name from count_leaves to num_leaves.

Not addressed: Simplification of tests. The tests are very thorough but there is a lot of repetition in them. The number of tests can probably be halved without affecting test coverage negatively.

coveralls commented 5 months ago

coverage: 97.58% (-0.08%) from 97.662% when pulling cd8fd0895f8a1522d406fbf83ec02b4e7ec42f75 on thv/remove-leaf-idx-from-mmr-mp into cb53ad642ede96930755bc67e7ecfa0aca14c6fa on master.

Sword-Smith commented 4 months ago

Lastly, without implying anything about the priorities of oughts, let me use the opportunity to cite for the record two lines from Alan's written style guide:

Trees in the forest, and plants in general, have leaves. Merkle trees have leafs.

I'm OK changing all occurrences of "leaves" to "leafs".

coveralls commented 4 months ago

coverage: 97.572% (-0.09%) from 97.662% when pulling 59ddc0e75ff23262f4dd756ff9eac547595bea48 on thv/remove-leaf-idx-from-mmr-mp into cb53ad642ede96930755bc67e7ecfa0aca14c6fa on master.

coveralls commented 4 months ago

coverage: 97.579% (-0.08%) from 97.662% when pulling b3973fc028ea43b918a8dfb5e53eb9fbcb685681 on thv/remove-leaf-idx-from-mmr-mp into cb53ad642ede96930755bc67e7ecfa0aca14c6fa on master.

coveralls commented 4 months ago

coverage: 97.572% (-0.09%) from 97.662% when pulling b3973fc028ea43b918a8dfb5e53eb9fbcb685681 on thv/remove-leaf-idx-from-mmr-mp into cb53ad642ede96930755bc67e7ecfa0aca14c6fa on master.