search

Neptune-Crypto / twenty-first

Collection of mathematics routines and cryptography for the twenty-first century
GNU General Public License v2.0
74 stars 22 forks source link

Remove generic from MerkleTree #230

Closed jan-ferdinand closed 3 months ago

jan-ferdinand commented 3 months ago

Previously, a Merkle tree could be built with any hash function implementing the AlgebraicHasher trait. Only one such hash function exists in the codebase: Tip5. The primary downstream consumers heavily rely on Tip5 being used when building a Merkle tree. It is not expected that any other hash function will replace Tip5. As a consequence, the generality of MerkleTree is considered an unnecessary overhead.

coveralls commented 3 months ago

Coverage Status

coverage: 97.712% (+0.006%) from 97.706% when pulling 920c5db5bc1f064ae08a25ea1cdf09a87b81307e on non_generic_tree into 65dc94d3ed678d44a3c55cf2bd2c017a2d5a76ed on master.