Move canon check from `Digest` to `BFieldElement`

Neptune-Crypto / twenty-first

Collection of mathematics routines and cryptography for the twenty-first century

GNU General Public License v2.0

74 stars 22 forks source link

Move canon check from `Digest` to `BFieldElement` #235

Closed jan-ferdinand closed 1 month ago

jan-ferdinand commented 1 month ago

Reject non-canonical BFieldElements when parsing string slices or interpreting byte sequences
Move canon check of BFieldElements from Digest to BFieldElement
Deprecate functionality for platform-dependent endianness when decoding

BREAKING CHANGE: The error variant NotCanonical from enum TryFromDigestError has moved into enum ParseBFieldElementError.

This was described as the cleaner solution in #199, a sentiment I concur with.

Supersedes #206.

coveralls commented 1 month ago

coverage: 97.79% (+0.03%) from 97.76% when pulling 7dafa32e0d636a89c372b18a566fcdc232409ee6 on bfield_parsing into 8482f939323817bd28f1f4c1810d9ca4fc56d33c on master.

jan-ferdinand commented 1 month ago

@Sword-Smith, any opposition?