Neraud / PADListener

Android application to sync PAD to PADherder
GNU General Public License v2.0
25 stars 18 forks source link

Only if already a monster in PADherder option doesn't work #42

Closed pkch closed 9 years ago

pkch commented 9 years ago

In Settings/Sync/Sync materials as monsters?, I chose "Only if already a monster...". Currently, in PADherder, I have 14 entries in the monster tab that are counted as materials by PADHerder (e.g., Keeper of Dark, etc.). When I sync, PADListener attempts to delete these 14 monsters, even though the option is supposed to let them stay (unless I misunderstand the meaning of this option).

Note: all the monsters in PADHerder were originally added by PADListener; I never added anything manually.

Neraud commented 9 years ago

That looks like a duplicate of #41.

pkch commented 9 years ago

I think #41 was talking about the confusion that results from the algorithm as intended. (Specifically, that the monsters are added/deleted in a loop as a result of the interaction of "Sync materials" and "Deduct materials" options.)

My issue is that the algorithm does not seem to work as intended. With the option "Sync materials" set to "Only if already a monster" and "Deduct materials" disabled, the outcome seems to be different than expected. I'd be happy to help you replicate the bug (assuming it is indeed a bug).

Neraud commented 9 years ago

The core issue is probably the same (my messing with the sync algorithm). I'll fix #41 this week-end and it'll very probably also fix this one.

Neraud commented 9 years ago

@mmoroz : could you please try again with the version I pushed to the PlayStore a few days ago (1.4.6) and report if the issue is still there ?

pkch commented 9 years ago

Looks good now!

On Tue, Aug 26, 2014 at 2:00 PM, Neraud notifications@github.com wrote:

@mmoroz https://github.com/mmoroz : could you please try again with the version I pushed to the PlayStore a few days ago (1.4.6) and report if the issue is still there ?

— Reply to this email directly or view it on GitHub https://github.com/Neraud/PADListener/issues/42#issuecomment-53491326.

Neraud commented 9 years ago

Great ! Thanks for the feedback.