NerdNumber9 / TachiyomiEH

Free and open source manga reader for Android
Apache License 2.0
334 stars 25 forks source link

E-(x)hentai redesign - browse and latest no longer work. #56

Closed Solipso closed 5 years ago

Solipso commented 5 years ago

App version: 7.4.4-EH Issue/Request: E-hentai (and fjords) have undergone a redesign, maybe changing how their main page works. Now Tachiyomi can no longer see galleries on these pages, so "Browse" and "Latest" show "No results found".

ghost commented 5 years ago

@Scrxtchy fixed the thumbnails issues: https://github.com/ilwaz/TachiyomiEH/releases/tag/v7.4.8-EH

joseph619 commented 5 years ago

@ilwaz Can't change thumbnails for local manga

Scrxtchy commented 5 years ago

@ilwaz Can't change thumbnails for local manga

I did not have a problem, I just had to reopen the application for it to take affect

joseph619 commented 5 years ago

@ilwaz Can't change thumbnails for local manga

I did not have a problem, I just had to reopen the application for it to take affect

Nope, still doesn't work. Not sure why.

Solipso commented 5 years ago

@joseph619 There was an issue like this before.

Try adding space in the end of folder of your local manga in /local/.

I mean change /local/example/ch1/ to /local/example /ch1/.

EDIT: This version actually doesn't need that space. Works fine even without it here.

Zero777X commented 5 years ago

Kissmanga is not working. SyntaxError: parse error (line 1)

ghost commented 5 years ago

@joseph619 @Zero777X this issue is to track the errors related to the e-hentai redesign, it would be easier to track those problems if you create a new issue (I guess in https://github.com/ilwaz/TachiyomiEH/ since this fork doesn't seem maintained)

vannessqn commented 5 years ago

isn't there is a well made e(x)-hentai app https://github.com/seven332/EhViewer?

Solipso commented 5 years ago

@vannessqn There is... but I personally prefer this one due to its reader, style, and, mainly, multiple sources

eagle540 commented 5 years ago

Just downloaded the update to the app and it works perfectly fine on like I'm accessing ehentai right now thanks to everyone you folks are amazing

Yandols commented 5 years ago

Can anyone confirm that favorites sync is working in the @ilwaz fork? I saw a comment in the earlier part of the thread that they had their favorites removed when syncing.

Scrxtchy commented 5 years ago

It works, I fixed it

Yandols commented 5 years ago

Thanks for confirming! I didn't want my favorites library to get thanos snapped.

CynicalRaven commented 5 years ago

i read everything here from the start and i think it's beautiful how you guys are cooperating to bring back the app, thanks !

Yandols commented 5 years ago

Restoring nearly 3000 favourites from backup is taking ages. Is there a way to use or move the existing library from the old app directly into the new one?

Additionally, I get a lot of Did not find balanced marker at 'alt=Representative image' and Attempt to invoke virtual method 'org.jsoup.select.Elements org.jsoup.nodes.Element.select(java.lang.String)' on a null object reference errors. I have no idea how to go about that.

Scrxtchy commented 5 years ago

I'm not entierly sure how the backup/restore feature functions. Looks like every time we add a new entry back into the new database, we check against the website for any data if it's not already stored within the app's database.

The only other way this would be faster is if we were installing versions of the app that were the same as you had installed, like off F-Droid or whatever. Ilwaz has been handling the build scripts because quite frankly I'm not even skilled at doing so. If you were able to install a newer version as an update to the one you had installed, the database would be preserved, and you will not need to restore the backup

Yandols commented 5 years ago

I've been using the github version of the NerdNumber9 fork before the redesign happened. I thought that the one you and Ilwaz worked on would be an update to replace it but it instead installs itself as a new app so everything is blank on it after I installed it while the old app is still intact.

ghost commented 5 years ago

Unfortunately, I do not have the signing key that NerdNumber9 used to build and sign TachiyomiEH. This means I have to use a new key and our releases can not be seen by Android as an update to the previously installed app (I also changed the package name so instead of being forced to uninstall the old version, you can have them side by side).

@Yandols, please make an issue here about the restoring from backup error messages. There may be a couple things we can try to do with speeding up restoring from backup in general (maybe instantly displaying all of the favorites, but in a background thread fetching all the information instead of making the user wait).

Zero777X commented 5 years ago

How does one fix Kissmanga for TachiyomiEH?

Solipso commented 5 years ago

@Zero777X Considering all commits done in Tachiyomi, fixing Kissmanga would mean merging commits from tachiyomi dev (and they are currently still working on it even now) as well as making sure that merged commits dont conflict with this fork. (And @ilwaz said that the merges do cause conflicts.)

Currently it would be easier to use normal Tachiyomi by Inorichi. At least until all local sources are working (at least somehow).

You could make an issue here, but it would be a part of this issue.

dundandien commented 5 years ago

It seem like the thumbnail picture in brows is broken again. Some was able to load but most was not.

Scrxtchy commented 5 years ago

It seem like the thumbnail picture in brows is broken again. Some was able to load but most was not.

yup, also noticing this

Scrxtchy commented 5 years ago

They have changed the thumbnail functions again...

<div>
    <img style="height:348px;width:250px;top:-4px" alt="(C95) [From nuts (Garana)] Producer-san Otsukaresama desu (THE IDOLM@STER CINDERELLA GIRLS)" title="(C95) [From nuts (Garana)] Producer-san Otsukaresama desu (THE IDOLM@STER CINDERELLA GIRLS)" src="data:image/gif;base64,R0lGODlhAQABAAAAACH5BAEKAAEALAAAAAABAAEAAAICTAEAOw==" data-src="https://exhentai.org/t/06/b7/06b72d375bede8f4eddd3945d5fc30e78aab978c-224061-1200-1669-jpg_250.jpg" />
</div>

Edit 4 minutes later; this is actually a good change I've already written a patch that should work

Scrxtchy commented 5 years ago

@dundandien https://github.com/ilwaz/TachiyomiEH/issues/20 👉 https://github.com/ilwaz/TachiyomiEH/pull/21

NerdNumber9 commented 5 years ago

Fixed in latest release.

Scrxtchy commented 5 years ago

Welcome back! 🎉

Zero777X commented 5 years ago

Welcome Back! 🎉 Great app and thanks for returning to fix it!

joseph619 commented 5 years ago

Welcome back man! Thanks for the new update 🎉

TheBaddest commented 5 years ago

sorry to necropost but I still can't access EH and EX, even after TachiyomiEH update v8.2.0-EH and updated all the extensions. 'Latest' just returns a blank page and 'Browse' returns "no results found".

joseph619 commented 5 years ago

sorry to necropost but I still can't access EH and EX, even after TachiyomiEH update v8.2.0-EH and updated all the extensions. 'Latest' just returns a blank page and 'Browse' returns "no results found".

Post a screenshot please, Eh and Ex works fine for me

TheBaddest commented 5 years ago

After clearing cache and cookies EH and EX works fine again. Sorry for the necropost for such a trivial matter.


From: joseph619 notifications@github.com Sent: Monday, April 8, 2019 4:41:35 AM To: NerdNumber9/TachiyomiEH Cc: TheBaddest; Manual Subject: Re: [NerdNumber9/TachiyomiEH] E-(x)hentai redesign - browse and latest no longer work. (#56)

sorry to necropost but I still can't access EH and EX, even after TachiyomiEH update v8.2.0-EH and updated all the extensions. 'Latest' just returns a blank page and 'Browse' returns "no results found".

Post a screenshot please, Eh and Ex works fine for me

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/NerdNumber9/TachiyomiEH/issues/56#issuecomment-480663747, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AMArZle0QROu6WhgmfH1kfeXo0V7sVBJks5veqxfgaJpZM4b8Cr0.

yalopov commented 5 years ago

Thanks for your work guys!