search

NerdNumber9 / TachiyomiEH

Free and open source manga reader for Android
Apache License 2.0
334 stars 25 forks source link

Filenames can be too long #83

Open Scrxtchy opened 5 years ago

Scrxtchy commented 5 years ago

E* Sources now provide the chapter name per revision, this can result in some very long filenames, some which contain the title of the source as it's chapter name

application will throw a java.io.FileNotFoundException here https://github.com/NerdNumber9/TachiyomiEH/blob/dce685e711de085c21b6590a3907c4523f661bfd/app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderPresenter.kt#L442-L461

Scrxtchy commented 5 years ago

Looked over my files for the first time (my image viewer does not display them, so I don't notice). Using the titles of the manga as the chapter name causes a double up every time, this may be a separate issue, but we should be making sure filename are not too long anyway

Scrxtchy commented 5 years ago

003dca9d45ff122cb24f176b314389e57b4ad7f1 A related patch does exist in the upstream