search

Nerds-Who-Code / Mental-Health-Tracker

mental-health-tracker.vercel.app
MIT License
6 stars 6 forks source link

added fonts for login, dashboard and add entry #31

Closed Trevy05 closed 2 years ago

Trevy05 commented 2 years ago

Hello, This is a pull request for issue #24

I added, fonts to the pages stated in the description. I didn't experiment with the color since the color scheme wasn't clearly defined. I made the changes by adding CSS class selectors to the App.css file in the client folder.

For the dashboard I went with Raleway: font-2 For the login I went with Roboto: fonts-1 For the add entry I went with Lora: font-3

If you want all of them to have one font family then I can easily make the changes. Since the issue stated that they wanted "fonts", I assumed they wanted many. But if I misunderstood, let me know and I can make the changes.

xintamosaik commented 2 years ago

Thank you! Great! I like the font selected. There are some minor issues.

  1. Since we use Tailwind we might move the CSS directives to index.css where all the Tailwind will be defined, but the import and the generall ideas still apply.
  2. It seems that your editor did a lot of small changes to files that are not relevant to your commit. That makes it hard to review. Can you remove irrelevant files from your commit?