search

NerdyPuzzle / MCreator-Player-Animator

MIT License
4 stars 0 forks source link

Idea for fixing Animations not working on servers #27

Closed pploh closed 4 months ago

pploh commented 11 months ago

So I know that there is a reoccurring issue with animations not working on servers, but i've seen mods with the plugin that got it to work on servers. I know no Java at all but going into each mod that has playerAnimator library, I've seen that they all have something similar to sending something from client to server, sending a packet to the server, etc. I'm not sure if you are able to do this because of MCreator limitations, but if you get the chance, could you please try the idea if you haven't previously.

NerdyPuzzle commented 11 months ago

if you link any mods' repositories that do it, send the link here and I'll take a look.

pploh commented 11 months ago

Sorry for taking so long, Better Combat had done something like this. My friends could see everyone's animations. https://github.com/ZsoltMolnarrr/BetterCombat/tree/1.18.2/forge/src/main/java/net/bettercombat/forge/events is the proper folder i think what we are looking for is in, the mod also has Cloth Config API if that makes a difference.

pploh commented 11 months ago

Not sure when you will be available again but I thought I'd just drop this here. I looked into the playerAnimator Source code itself and it mentions " //You can set an animation from anywhere ON THE CLIENT //Do not attempt to do this on a server, that will only fail"

But upon looking further it says "//For server-side animation playing, see Emotecraft API" So from what I understand, for server side animations, the Emotecraft API would have to be worked into the plugin or just a whole different plugin entirely. Here is to the link to the file that I think might be what were are looking for https://github.com/KosmX/emotes/blob/dev/18/forge/src/main/java/io/github/kosmx/emotes/forge/mixin/ServerPlayNetworkInstance.java